[MPlayer-dev-eng] [PATCH] SGI IRIX audio format fixes

[Reimar Döffinger]

Hi,
On Sat, Sep 03, 2005 at 11:24:12PM -0400, dega wrote:
> Okay, so here is the patch again. It adds the man page section and
> incorporates Reimar's suggestions: does not use low-level format defines,
> and does not provide its own unsigned->signed conversion code.
> 
> It still does convert 32bit->24bit on the fly, but I see no clean way
> around this for now. If libaf ever adds support for the non-packed 24-bit
> format, I will gladly update this driver to make use of that.
> 
> Please let me know if this is now acceptable.

Looks okay to me, if you have objections speak up now or I will apply
it, even though I can not test it.
Though I have one question not directly related to the patch: why is
sginap used (that needs another header) instead of e.g. usec_sleep
that would also allow to just sleep the right time instead of risking
a hang with a while loop?

Greetings,
Reimar Döffinger