[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Christoph Egger]

> Hi,
> On Thu, Sep 08, 2005 at 08:10:07PM +0200, Christoph Egger wrote:
> > > How about addressing Reimar's review now?  He had some questions and
> > > suggested some improvements.
> > 
> > I did. I changed the if in get_image() as he suggested.
> > 
> > And to answer his question about ggi_conf.async - this variable
> > was only used for debugging and thus removed. The actual asynchronous
> > mode is set via ggiSetFlags()
> 
> That leaves the questions why you moved some things (draw_slice
> function, async setting, ), and I consider this cosmetics:
> -    if ((char *) arg) {
> +    if (arg != NULL) {
>        int i = 0;
>        ggi_conf.driver = strdup(arg);
> -        while (ggi_conf.driver[i]) {
> +        while (ggi_conf.driver[i] != '\0') {

Why do you call this a cosmetic change?
The compilers parser, syntax analyser, etc. handles this differently.
And the internal syntax tree is also different.

the 'arg' is a const char * by function parameter.
Casting it to char * disqualifies this datatype for no reason.
I call this a bug. Don't know what you ever learned about
type safety (in C, pascal, java, etc.).

-- 
Greetings,

Christoph

Lust, ein paar Euro nebenbei zu verdienen? Ohne Kosten, ohne Risiko!
Satte Provisionen für GMX Partner: http://www.gmx.net/de/go/partner