[MPlayer-dev-eng] mplayer w/i iconv font_fontconfig bug. (patch included)

[Yuri Vasilevski]

Hi,

When compiling mplayer on a uClibc based system without iconv, mplayers
configuration became with HAVE_FREETYPE undefined (depends on iconv)
and HAVE_FONTCONFIG defined. This caused the following link errors:

mplayer.o: In function `main':
mplayer.c:(.text+0x1429): undefined reference to `font_fontconfig'
mplayer.o:(.data+0x229c): undefined reference to `font_fontconfig'
mplayer.o:(.data+0x22c0): undefined reference to `font_fontconfig'
collect2: ld returned 1 exit status

Inspecting the code, font_fontconfig only gets used if HAVE_FONTCONFIG
is defined, but it's actual declaration is dependant on HAVE_FREETYPE
being defined. So I include a patch to correct this situation, it makes
font_fontconfig declaration dependant on HAVE_FONTCONFIG.

Another solution may also be making HAVE_FONTCONFIG dependant on
HAVE_FREETYPE at configure time in the same way as HAVE_FREETYPE is
dependant on iconv, but I don't know enough about mplayer's inerworking
to understand witch of this solutions is the one that makes most sense.

Yuri.

PS: My apologies if this message gets posted twice as the first time I
    was unsubscribed so I got the standard "you are spam until a
    moderator says you are not" message, but the url to cancel its
    delivery was wrong (404).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-1.0_pre7-r1-fontconfig.patch
Type: text/x-patch
Size: 449 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050908/ea6c872a/attachment.bin>