[MPlayer-dev-eng] [PATCH] MP3 early EOF

Thu Sep 8 12:10:32 CEST 2005

Hi,
On Wed, Sep 07, 2005 at 08:10:50PM -0700, RC wrote:
> MPlayer exits prematurely when playing a small MP3 file that grows
> during playback.  It seems to be hitting the EOF early.  This was
> discussed on mplayer-users:  
> 
> Message-Id: <200508270834.58405.kdekorte at yahoo.com>
> http://mplayerhq.hu/pipermail/mplayer-users/2005-August/055297.html
> 
> This simple patch fixes the problem.

Rejected. What you are actually doing is disabling the audio demuxer.
It will completely break MP3 playback for anyone who does not have
libavformat.
In my test the current code never read more than 5k, so after
downloading 5k + cache size it should work fine with current code.
You might also change the MIN_MP3_HEADERS define, but you should be
aware that all these are just hacks around the real problem (which is
that MPlayer does not know that the file is not yet complete).

Greetings,
Reimar DÃ¶ffinger