[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

Christoph Egger Christoph_Egger at gmx.de
Tue Sep 6 19:05:29 CEST 2005


> On Tuesday 06 September 2005 16:56, Christoph Egger wrote:
> > Yeah, this is the main argument of my professors, too :)
> > I had a real discussion about this topic with them. The personal
> > preferences come mainly from which IDE or editor you use.
> > (I learned C in a time, where most people used pico, joe and vi :)
> 
> I use vi(m) too. When I switched from using tabs to spaces, I put this in
> my vimrc file:
> 
> set expandtab
> set tabstop=4
> set shiftwidth=4
> 
> > Should I run sed -e 's;\t;   ;g' vo_ggi.c and resend the patch with
> > cosmetic changes? If yes, how many spaces for indentation is prefered?
> 
> Like Diego said, four. And since you're doing a one-time cosmetics patch, 
> you might also want to run:
> 
> ../TOOLS/checktree.sh -noall -crlf -trailws -oll vo_ggi.c
> 
> to fix trailing whitespace, overly long lines, etc..

Here we go: The cosmetic patch with spaces only.
The checktree.sh just prints of what it is checking for in lightblue
color.

-- 
Greetings,

Christoph

Lust, ein paar Euro nebenbei zu verdienen? Ohne Kosten, ohne Risiko!
Satte Provisionen für GMX Partner: http://www.gmx.net/de/go/partner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_ggi.c.cosmetic_diff
Type: application/octet-stream
Size: 22189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050906/2a92634b/attachment.obj>


More information about the MPlayer-dev-eng mailing list