[MPlayer-dev-eng] [PATCH] nvidia vidix AMD64, equalizer etc.

[Sascha Sommer]

Hi,

On Sunday 04 September 2005 23:24, Reimar Döffinger wrote:
> Hi,
>
> On Sat, Sep 03, 2005 at 12:43:57PM +0200, Sascha Sommer wrote:
> > I'm not sure if riva128 and TNT cards have a hw equalizer at all.
>
> Seems like not really, but I implemented brightness control for them, at
> least that works for my Riva128ZX.

Thanks.

> But about that
> if(!y)y = info->wy+8;
> First of all, from testing with the Riva it seem that any value < 7
> causes a flickering white line, so shouldn't this probably be
> if (y < 8) y = 8; ?
> Also with my NV36 a value of 0 doesn't give any problems. What cards do
> you know for sure this is necessary for? Because I'm thinking something
> like this might be better:
> if (info->chip.arch < NV_ARCH_10 && y < 8) y = 8;

Yes.

> Of course I have no idea if NV_ARCH_10 is right (and I didn't test if my
> NV36 maybe just doesn't make problems because a LCD and not a CRT is
> connected to it).
>

No idea.
There shouldn't be a problem if you have rivafb running anyway. Afair is the 
aspect in textmode wrong, too. Commit whatever solution you prefer.

Regards

Sascha