[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Ivo]

On Tuesday 06 September 2005 16:56, Christoph Egger wrote:
> Yeah, this is the main argument of my professors, too :)
> I had a real discussion about this topic with them. The personal
> preferences come mainly from which IDE or editor you use.
> (I learned C in a time, where most people used pico, joe and vi :)

I use vi(m) too. When I switched from using tabs to spaces, I put this in my 
vimrc file:

set expandtab
set tabstop=4
set shiftwidth=4

> Should I run sed -e 's;\t;   ;g' vo_ggi.c and resend the patch with
> cosmetic changes? If yes, how many spaces for indentation is prefered?

Like Diego said, four. And since you're doing a one-time cosmetics patch, 
you might also want to run:

../TOOLS/checktree.sh -noall -crlf -trailws -oll vo_ggi.c

to fix trailing whitespace, overly long lines, etc..

--Ivo