[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Christoph Egger]

> On Tuesday 06 September 2005 15:24, Christoph Egger wrote:
> > I can live that statement.
> > What is the mplayer's _general_ coding style?
> 
> AFAIK there's no such thing.

ok, that explains things.

> > I'm told be the maintainer for the ggi driver (However, I'm not aware
> > of any account information). The code in CVS (up to rev 1.37) is a mix
> > of tabs and spaces. I believe this state comes over time from different
> > people, one likes tabs, the other likes spaces...
> > As a maintainer I should have the right to
> > say 'Stop. Please don't make it worse...'
> 
> Yes. The maintainer of a certain piece of code decides on the layout of
> that code, so if you really want tabs in there, I guess that's allright,
> but I agree with Reimar. I prefer spaces instead of tabs. That will look
> the same everywhere,

Yeah, this is the main argument of my professors, too :)
I had a real discussion about this topic with them. The personal
preferences come mainly from which IDE or editor you use.
(I learned C in a time, where most people used pico, joe and vi :)

> despite the tabwidth settings. When I looked at
> your patch the first time, I thought there were numerous lines of 90+
> characters, until I found out you used tabs all over the place.

Should I run sed -e 's;\t;   ;g' vo_ggi.c and resend the patch with
cosmetic changes? If yes, how many spaces for indentation is prefered?


-- 
Greetings,

Christoph

5 GB Mailbox, 50 FreeSMS http://www.gmx.net/de/go/promail
+++ GMX - die erste Adresse für Mail, Message, More +++