[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Reimar Döffinger]

Hi,
On Tue, Sep 06, 2005 at 01:34:58PM +0200, Christoph Egger wrote:
> > The version which is currently in CVS mixes tabs and spaces.
> > This patch switches to tabs only (and overall codingstyle to K&R)

I personally prefer spaces only, since they always have the same size,
and I also think you would have to do less changes.

> I'll attach the patch with the cosmetic changes only again.
> Just to be sure you look into the _right_ patch.

So the switch and case statements are supposed to be on the same level?
line 77 from the patch
+	switch(format) {
 	case IMGFMT_RGB4:
Well, not my style..

And there still are space used e.g. here (line 398):
 #if 1
-       (IMGFMT_IS_RGB(mpi->imgfmt) &&
+           (IMGFMT_IS_RGB(mpi->imgfmt) &&
            (IMGFMT_RGB_DEPTH(mpi->imgfmt) != vo_dbpp)) ||
-       (IMGFMT_IS_BGR(mpi->imgfmt) &&
+           (IMGFMT_IS_BGR(mpi->imgfmt) &&
            (IMGFMT_BGR_DEPTH(mpi->imgfmt) != vo_dbpp)) ||

I can't believe I'm reviewing a cosmetics patch, and to put it bluntly,
I don't know if you'll actually find someone applying this (unless you
get CVS access yourself).

Greetings,
Reimar Döffinger