[MPlayer-dev-eng] [PATCH] SGI IRIX audio format fixes

[Reimar Döffinger]

Hi,
On Sat, Sep 03, 2005 at 11:24:50AM -0400, dega wrote:
> Nothing in af_format.h indicates which #defines are meant for public use,
> and which ones are considered 'internal'. If there is a distinction
> between low-level and high-level #defines, then there should at least be
> a comment to that effect somewhere in af_format.h. Ideally, the non-public
> #defines should be in a separate header file.

Wel, they are not really non-public, just IMHO a bit low-level, and
using them often might make future changes difficult. But to
tell the truth, I just had a bad feeling about it, so I looked for a
reason why, and that was what I came up with.
Another reason is that with a big switch-case with all the supported
formats listed, it makes it easier to find out which should be supported
and what the differences are, also making debugging easier because those
predefined are printed almost directly in the MPlayer output.

Greetings,
Reimar Döffinger