[MPlayer-dev-eng] [PATCH] nvidia vidix AMD64, equalizer etc.

[Sascha Sommer]

On Thursday 01 September 2005 18:56, Reimar Döffinger wrote:
> Hi,
> the attached patch fixes several things (I sent the all in one patch to
> get comments).
> 1) It adds FX Go 5700 to the supported cards.

ok

> 2) It changes some int / int32_t to intptr_t to make it work in 64 bit

Did you check if intprt_t is portable? If not change it to char* .

> 3) changes some ifdefs in libdha/mtrr.c so it will work on AMD64

ok

> 4) Adds equalizer support (brightness, contrast, saturation and hue).
> Somebody should test on older hardware

I'll try to add support for riva128

> 5) changes int x=info->wx?info->wx:8, y=info->wy?info->wy:8; to
> int x=info->wx, y=info->wy; since it gives ugly borders on top and right
> with cvidix and fullscreen. Why was this done? Is this needed for some
> cards? Removing it gave no problems for me and fixed the issue with
> cvidix...
>

It is required for overlay in textmode for riva128 cards, because we can't 
calculate pan due to the missing depth. Given that people keep requesting
this change and probably not many of the old cards are still in use today, 
even less on plain textmode, it is ok for me to change this, too.

> Please comment and test (and maybe at least the list of supported devices
> should be synced from upstream).
>

An update of pci.db is needed to do this. Due to name changes, false entries 
etc. this will also affect other drivers.
I wonder if it wouldn't be better to use the plain numbers instead of the 
defines.

Regards

Sascha