[MPlayer-dev-eng] [PATCH] SGI IRIX audio format fixes

[Diego Biurrun]

On Wed, Aug 31, 2005 at 11:18:29PM -0400, dega wrote:
> The attached patch fixes the following problems with the current IRIX
> audio driver (ao_sgi):
> 
> - plays noise when handed unsigned audio streams
> - plays twice/half as fast when handed 8bit/32bit audio streams
> - plays noise when handed 24-bit audio streams
> - accepts little endian audio streams, then plays noise
> - float audio streams are not handled correctly
> - always sets the sample rate on the first analog output
>   channel, even when the default output channel is
>   something else (i.e. digital output, analog out 2),
>   potentially resulting in incorrect sample rate
> - does not set ao_data.bps
> - does not update ao_data.samplerate when requested rate cannot
>   be set
>   - esp. important when using digital out, which cannot go
>     below 32KHz
> - returns inaccurate value in get_delay()
> 
> A side effect of the channel selection fix is that it is now possible to
> override the default audio device from the command line:
> 
> -ao sgi:<device_name>
> 
> On Indy/Indigo/Indigo2/Onyx, one can say, for example, sgi:"Digital Out".
> Use "audiopanel -print" to get the list of audio device names.

This needs to be documented in the man page.
 
> I've tested the fix on Indigo2, Onyx (with ASO) and O2.

Hmm, what to do about this patch?  Can somebody look this over quickly
and confirm it's OK?  Exotic platforms are troublesome when it comes to
applying patches.  If it works for the patch sender it should probably
get applied IMO.

Nicolas, don't you have an SGI machine to test?

Diego