[MPlayer-dev-eng] [PATCH] suboption escaping

Oded Shimon ods15 at ods15.dyndns.org
Fri Sep 2 17:06:02 CEST 2005


On Fri, Sep 02, 2005 at 11:00:30AM -0400, Rich Felker wrote:
> On Fri, Sep 02, 2005 at 09:49:07AM +0300, Oded Shimon wrote:
> > On Fri, Sep 02, 2005 at 12:14:07AM +0200, Reimar D?ffinger wrote:
> > > Hi,
> > > On Thu, Sep 01, 2005 at 04:33:14PM -0500, Joey Parrish wrote:
> > > > I'm still in favor of backslash escaping.  I'm going to post a new patch
> > > > with documentation in a new thread.  I've also modified the code to
> > > > address most of the issues you brought up with the first patch.
> > > 
> > > I actually just disliked the strtokex function, it seemed overkill for
> > > me. Can't you just extend my patch for backslash escaping?
> > > I think the quotes should stay in, since they can be included in the
> > > subopt parser, the backslash escapig can't.
> > 
> > I actually dislike ALL this escaping stuff, escaping should be purely up to 
> > the shell, not the program :/ which is why i'm not sure i'm so in favor of 
> > the whole sub opt thing..
> 
> Huh? You're smoking crack.. there's no way this can be up to the
> shell.

What I mean is, options should be seperated by argv[], not by string 
manipulation...

- ods15




More information about the MPlayer-dev-eng mailing list