[MPlayer-dev-eng] [PATCH] CQMs in x264

[Guillaume POIRIER]

Hi,

On 9/2/05, Robert Swain <robert.swain at gmail.com> wrote:
> Hello everyone,
> 
> How's this?

Fine with me. You did address Reimar's comment. 

I will apply it tonight is no one objects (all cola on me), and if you
can come up with a comment to add before the block:

+    if( (cqm4iy && parse_cqm(cqm4iy, mod->param.cqm_4iy, 16, mod,
"4iy") < 0) || \
+        (cqm4ic && parse_cqm(cqm4ic, mod->param.cqm_4ic, 16, mod,
"4ic") < 0) || \
+        (cqm4py && parse_cqm(cqm4py, mod->param.cqm_4py, 16, mod,
"4py") < 0) || \
+        (cqm4pc && parse_cqm(cqm4pc, mod->param.cqm_4pc, 16, mod,
"4pc") < 0) || \
+        (cqm8iy && parse_cqm(cqm8iy, mod->param.cqm_8iy, 64, mod,
"8iy") < 0) || \
+        (cqm8py && parse_cqm(cqm8py, mod->param.cqm_8py, 64, mod, "8py") < 0) )
+        return 0;

If I'm not mistaken, this makes sure all the CQM are valid, and cries
if it doesn't.

I personnaly don't like too much this coding style (I'd prbably have
used if/else), but it is readable, which is all what counts.

Robert, if you could run as much test as possible with that code, that
would be just fantastic.

Guillaume
-- 
Reading doesn't hurt, really!
 -- Dominik 'Rathann' Mierzejewski