[MPlayer-dev-eng] Re: [PATCH] Cleanup the libvo/input hacks

Diego Biurrun diego at biurrun.de
Sun Oct 30 12:25:41 CET 2005


On Sat, Oct 29, 2005 at 01:11:57PM +0200, Alban Bedel wrote:
> On Sat, 29 Oct 2005 00:21:17 +0200
> Alban Bedel <albeu at free.fr> wrote:
> 
> > Following up the discussion on cvs-log i made the changes. While at it
> > i did a little more cleanup. So this patch:
> > 
> >  * Remove all call to libinput functions from libvo (closing the window in
> >    win32).
> >  * Define new keys for vo dfbmga and put some default mappings.
> >  * Remove the hacks in the x11 input (like mapping O to o, Q to q, etc).
> > 
> > A bit of testing would be nice as i can't test the win32 and dfb parts.
> 
> It seems it was a bit too late and a few 10L sliped in :) Here come an
> updated version that also fix a couple other vo.

I don't think it's a good idea to use uppercase as well as lowercase
keys.  Why is this necessary?

Diego




More information about the MPlayer-dev-eng mailing list