[MPlayer-dev-eng] Re: [PATCH] Cleanup the libvo/input hacks

[Reimar Döffinger]

Hi,
On Sat, Oct 29, 2005 at 01:11:57PM +0200, Alban Bedel wrote:
> On Sat, 29 Oct 2005 00:21:17 +0200
> Alban Bedel <albeu at free.fr> wrote:
> > Hi all,
> > 
> > Following up the discussion on cvs-log i made the changes. While at it
> > i did a little more cleanup. So this patch:
> > 
> >  * Remove all call to libinput functions from libvo (closing the window in
> >    win32).
> >  * Define new keys for vo dfbmga and put some default mappings.
> >  * Remove the hacks in the x11 input (like mapping O to o, Q to q, etc).

By making the hack of mapping 'O' and 'Q' that could be used free
before, too? This seems wrong to me. Why is this needed anyway?

> > A bit of testing would be nice as i can't test the win32 and dfb parts.
> 
> It seems it was a bit too late and a few 10L sliped in :) Here come an
> updated version that also fix a couple other vo.

IMHO using
mplayer_put_key(KEY_CLOSE_WIN);
instead of
mp_input_queue_cmd(mp_input_parse_cmd("quit"));
is a giant hack. This just is not a key event, it is some completely
different thing that should make MPlayer quit, and not maybe something
else the user happened to assign to that key.
If you really think a input dependency is a problem, we can still introduce
a mplayer_put_command function.
Also, how sure is it that the KEY_INTERN definition is colission-free?
Maybe I'm missing something, but currently this has a very bad smell for
me.

Greetings,
Reimar Döffinger