[MPlayer-dev-eng] [PATCH] lrintf undefined in faabdct.o

[Guillaume Poirier]

Steven M. Schultz wrote:
> Hi -
> 
> 	On a BSD system:
> 
> moe.90-> gmake
> cc -I../libvo -I../../libvo -I/usr/X11/include -fno-PIC -O4 -march=i686 -mcpu=i686 -pipe -ffast-math -fomit-frame-pointer -D_THREAD_SAFE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE  -I.      -I/usr/local/include -I/usr/local/include/freetype2  -I/usr/local/include/SDL -D_REENTRANT -D_THREAD_SAFE -I/usr/X11/include   -I./libavutil -I./libavcodec  -o mplayer mplayer.o mp_msg.o asxparser.o codec-cfg.o cpudetect.o edl.o find_sub.o m_config.o m_option.o m_struct.o parser-cfg.o playtree.o playtreeparser.o spudec.o sub_cc.o subreader.o vobsub.o  unrarlib.o mixer.o parser-mpcmd.o subopt-helper.o  libvo/libvo.a libao2/libao2.a  vidix/libvidix.a  libmpcodecs/libmpcodecs.a   libaf/libaf.a libmpdemux/libmpdemux.a input/libinput.a postproc/libswscale.a osdep/libosdep.a -ldvdread libavformat/libavformat.a libavcodec/libavcodec.a libavutil/libavutil.a   -lmad -ldv  -lfaad -llzo -lmp3lame  -lxvidcore  -lpng -lz -lz -ljpeg      -lfaac -L/usr/local/lib -lfreetype -lz -lt
ermcap  /packages/live/liveMedia/libliveMedia.a /packages/live/groupsock/libgroupsock.a /packages/live/UsageEnvironment/libUsageEnvironment.a /packages/live/BasicUsageEnvironment/libBasicUsageEnvironment.a -lstdc++           mp3lib/libMP3.a liba52/liba52.a libmpeg2/libmpeg2.a tremor/libvorbisidec.a   -lGL -ldl -lXxf86dga -lXv  -lXxf86vm -lXinerama -L/usr/X11R6/lib -lXext -lX11    -L/usr/local/lib -Wl,-rpath,/usr/local/lib -lSDL -lm -ldl -L/usr/X11R6/lib -lX11 -lXext          -L/usr/contrib/lib -lesd -laudiofile -lm      -Wl,-z,noexecstack -L/usr/local/lib    -ldl -rdynamic -ldvd -liconv -lintl -lm 
> libavcodec/libavcodec.a(faandct.o): In function `ff_faandct':
> faandct.o(.text+0x299): undefined reference to `lrintf'
> faandct.o(.text+0x2b8): undefined reference to `lrintf'
> faandct.o(.text+0x300): undefined reference to `lrintf'
> faandct.o(.text+0x31f): undefined reference to `lrintf'
> faandct.o(.text+0x3e7): undefined reference to `lrintf'
> libavcodec/libavcodec.a(faandct.o)(.text+0x406): more undefined references to `lrintf' follow
> 
> 	Trivial patch (attached) is to '#include "avcodec.h"' (to get the
> 	inline'd lrintf definition in scope) in faandct.c
> 
> 	Cheers,
> 	Steven Schultz
> 
> 
> ------------------------------------------------------------------------
> 
> --- libavcodec/faandct.c.dist	Mon May 24 10:30:07 2004
> +++ libavcodec/faandct.c	Tue Oct 25 21:51:59 2005
> @@ -26,6 +26,7 @@
>   * @author Michael Niedermayer <michaelni at gmx.at>
>   */
>  
> +#include "avcodec.h"
>  #include "dsputil.h"
>  #include "faandct.h"
>  
> 
> 
> ------------------------------------------------------------------------


As this patch is against libavcodec source, it should be posted on
ffmpeg's ML IMHO... Well, only if this patch is needed at all! The
original source file faandct.c on your disk is from May 24 10:30:07
2004, which is about a year and a half ago! Patches are to be made
against latest CVS, which I doubt is what you've done here...

Could you please check if your patch is still necessary?

Guillaume
-- 
Reading doesn't hurt, really!
 -- Dominik 'Rathann' Mierzejewski