[MPlayer-dev-eng] [PATCH] Use external libs to handle rar subtitles

Diego Biurrun diego at biurrun.de
Tue Oct 25 14:46:07 CEST 2005


On Tue, Oct 25, 2005 at 01:26:36PM +0300, Ivan Kalvachev wrote:
> 2005/10/24, Zuxy <zuxy.meng at gmail.com>:
> > Discard UniquE; minimal (one line) change to vobsub.c. Tested on
> > mingw32 and FC4.
> 
> Patch rejected.
> 
> You should not remove the current build-in GPL  support for rar, as
> user may not have the propriately unrar3 lib.
> So you need to let configure check for unrar3 lib. Then make mplayer
> use build-in _or_ unrar3.

I think this is a good point that needs to be discussed.

Does it make sense for MPlayer to keep the built-in RAR support at all?
Especially given the fact that it's not the latest version and thus
mostly useless?  I can imagine using different external decompressor
libs/whatever depending on necessity.  This year it's RAR, the next it's
FOOBAR...

Diego




More information about the MPlayer-dev-eng mailing list