[MPlayer-dev-eng] [PATCH] configure to detect prescott and nocona

Corey Hickey bugfood-ml at fatooh.org
Mon Oct 24 20:09:37 CEST 2005


Diego Biurrun wrote:
>>I moved a part of the x86 section wherein configure sets pname, pvendor,
>>etc.. This is now its own section, and is run 'if (x86 || x86_64)'
> 
> What would be the advantage of that?

It's actually essential for allowing the amd64 optimization to work,
which uses a 'case "$pvendor" in' to decide what optimizations to try.

-----------------------------------------------------------------------
case "$pvendor" in
AuthenticAMD)
  proc=k8;;
  GenuineIntel)
  # 64-bit prescotts exist, but as far as GCC is concerned they have the
  # same capabilities as a nocona.
  proc=nocona;;
*)
  proc=error;;
esac
-----------------------------------------------------------------------

I moved the whole block surrounding pvendor because those lines all go
together, and in the future the x86_64 checks will probably depend on
other variables set there.

> OK, but you forgot to add pentium-m to the section where compiler
> capabilities are checked below..

Thanks for spotting that.

> Patch applied with some modifications and without moving the section.

Could you please do so now? Applying my patch without that part breaks
all x86_64 optimization. I've attached a new patch.

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix-configure.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051024/8df69234/attachment.asc>


More information about the MPlayer-dev-eng mailing list