[MPlayer-dev-eng] [PATCH] fix dvd miscompilation
dalias at aerifal.cx
Mon Oct 24 19:07:19 CEST 2005
On Mon, Oct 24, 2005 at 06:49:17PM +0200, Moritz Bunkus wrote:
> On Sunday 23 October 2005 21:03, Nico Sabbi wrote:
> > technique that I
> > abhor) , because there are some global variables in the file that are
> > used by demux_mkv.
> > When Moritz fixes that bad behavior we can conditionally compile
> > stream_dvd.c
> As far as I can see it's only dvd_chapter and dvd_last_chapter that are
> used by demux_mkv.c. Please try the attached patch. It "#ifdef
> HAVE_DVD"s the appropriate parts in demux_mkv.c.
IMO it's incorrect to disable chapter functionality in mkv just
because dvd support is not enabled! Instead the chapter stuff should
be taken out of dvd demuxer and put in a common place..
More information about the MPlayer-dev-eng