[MPlayer-dev-eng] [PATCH] partial bigendian support for nvidia_vid

Diego Biurrun diego at biurrun.de
Mon Oct 24 15:15:51 CEST 2005


On Mon, Oct 24, 2005 at 02:50:00PM +0200, Guillaume POIRIER wrote:
> 
> On 10/24/05, Diego Biurrun <diego at biurrun.de> wrote:
> > Sascha,
> >
> > this removes to le2me_32 macros from nvidia_vid.c since apparently the
> > values are already in machine endian order.  It's not enough for a
> > complete bigendian port, but it is a necessary step and simplifies the
> > code somewhat.
> >
> > OK to commit?  You wrote this yourself, so I assume it is safe, but I
> > cannot test on x86, so I'd love to hear a quick go ahead for this.
> 
> You're missing the patch...

*sigh*

Here it is ...

Diego
-------------- next part --------------
Index: vidix/drivers/nvidia_vid.c
===================================================================
RCS file: /cvsroot/mplayer/main/vidix/drivers/nvidia_vid.c,v
retrieving revision 1.31
diff -u -r1.31 nvidia_vid.c
--- vidix/drivers/nvidia_vid.c	6 Sep 2005 20:50:10 -0000	1.31
+++ vidix/drivers/nvidia_vid.c	24 Oct 2005 11:17:33 -0000
@@ -216,9 +216,9 @@
 #define VID_RD08(p,i)     ({ MEM_BARRIER(); ((uint8_t *)(p))[(i)]; })
 
 #undef	VID_WR32
-#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=le2me_32(val); })
+#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=val; })
 #undef	VID_RD32
-#define VID_RD32(p,i)     ({ MEM_BARRIER(); le2me_32(((uint32_t *)(p))[(i)/4]); })
+#define VID_RD32(p,i)     ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]; })
 
 #define VID_AND32(p,i,val) VID_WR32(p,i,VID_RD32(p,i)&(val))
 #define VID_OR32(p,i,val)  VID_WR32(p,i,VID_RD32(p,i)|(val))


More information about the MPlayer-dev-eng mailing list