[MPlayer-dev-eng] [PATCH] fix dvd miscompilation
Diego Biurrun
diego at biurrun.de
Mon Oct 24 01:36:01 CEST 2005
On Sun, Oct 23, 2005 at 09:03:12PM +0200, Nico Sabbi wrote:
> this patch fixes compilation when you specify --disable-mpdvdkit
> --disable-dvdread.
>
> I added to configure two variables to export to config.mak and config.h:
> DVDREAD (currently unused, but may be necessary later)
> and HAVE_DVD ("yes" if any of mkdvdkit1/2 or dvdread is "yes").
>
> I had to #ifdef HAVE_DVD almost all the code in stream_dvd.c (a
> technique that I
> abhor) , because there are some global variables in the file that are
> used by demux_mkv.
> When Moritz fixes that bad behavior we can conditionally compile
> stream_dvd.c
> (adding in Makefile an ifeq($(HAVE_DVD),yes).
Hmm, maybe we can fix this properly right away if Moritz can come up
with a fix...
Moritz?
Diego
More information about the MPlayer-dev-eng
mailing list