[MPlayer-dev-eng] [PATCH] OSD localization first try

[Paul TT]

On Sun, 23 Oct 2005 03:29:35 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Sat, Oct 22, 2005 at 03:49:50PM +0200, Paul TT wrote:
> > 
> > PS: note that this patch also resloves a bug about osd alignment
> > (bottom and top where wrong....)
> 
> That should go in a different patch.

sorry, next time i'll know & i'll do that way...

> Anyway, I think the current code is correct:
> 
>   if (osd_show_sub_alignment) {
>     snprintf(osd_text_tmp, 63, "Sub alignment: %s",
>       (sub_alignment == 2 ? "bottom" :
>       (sub_alignment == 1 ? "center" : "top")));
>     osd_show_sub_alignment--;
> 
> This agrees with the man page entry:
> 
>   -spualign <-1-2> (OSD only)
>     Specify  how  SPU  (DVD/VOBsub) subtitles should be aligned.
>       -1   original position
>        0   Align at top (default).
>        1   Align at center.
>        2   Align at bottom.
> 
> So what gives?

yes. you're right.
the code of mplayer.c is indeed right, i checked. it seems that the
wrong code is located in libvo/sub.c.....

writing a patch...