[MPlayer-dev-eng] Utilize libunrar.so/unrar.dll?

[Jindrich Makovicka]

Reimar Döffinger wrote:
> Hi,
> On Sat, Oct 22, 2005 at 11:46:31AM +0200, Jindrich Makovicka wrote:
> 
>>Reimar Döffinger wrote:
>>
>>>True (the patch part, not sure about the dlopen part). But that code there 
>>>is
>>>so broken I doubt someone can make a clean patch. And I'd also like to say
>>>that I find gzip/bzip2 support more important...
>>
>>I currently use mplayer with bzip2 support instead of unrar, as it is 
>>currently rather useless. It could be eventually modified to support 
>>both, or rar&bz2&gz. Patch is attached.
> 
> 
> Huh? IMHO your patch isn't any better starting point than the current
> code. The problem is that it's impossible to support different methods
> without actually rewriting most of the code.

You just need one *_open() function per format with some wrapper trying 
each of them. At least as long as the vobsubs will be decompressed to 
RAM at once during opening. Rest of the code can stay the same.

-- 
Jindrich Makovicka