[MPlayer-dev-eng] [PATCH] libmpdvdkit2/dvd_reader.c: do not second-guess user

[Arpi]

Hi,

> On Thu, Oct 13, 2005 at 10:14:32PM +0200, Reimar Döffinger wrote:
> > the attached patch stops MPlayer from using the dvd device instead of
> > the directory given by -dvd-device. This is just annoying and I don't
> > see any point in it.
> 
> I'm just wondering: When and how is this a problem?
> 
> Diego

if you have a badly mastered .iso image (or burned dvd disc), you
cannot play it with mplayer, as it expects the vob data at given
lba sector positions stored in teh ifo file.
(if it's badly mastered - then the sector positions in udf filesystem
directory and in the .ifo file mismatch. it happens if you just burn
the video_ts directory as normal files, not as a video dvd format disc)

a simplw workaround is mounting the disc/image and run mplayer on
the filesystem, insteda on the .iso file.
(so libdvdread emulates the udf filesystem based on data from .ifo
- thus they match)

but libdvdread also recognizes if the given path is mounted from a device
(based on mount tab), and then uses the raw device itself instead of the
filesystem. it's required to handle mounted css-encrypted disks.
(before you ask: why dont the user give the device insteda of the path
in this case? because on some OSes it's quite difficult to know the device
name, esp. on device mappers and other messy devfs-like systems, while you
can easily know the mount point, not even mentioning windows, where you
dont have device names, just drives which are actually paths...)

the best would be adding a -dvd-filesystem or such option, and patch
libdvdread to handle it.
so if you use -dvd-device path, it will know you want to use the device,
located based on the given path, and if you use -dvd-filesystem  then
you want to use file access instead of raw sector-based addressing.


A'rpi