[MPlayer-dev-eng] [PATCH] CPU detection related

[Guillaume POIRIER]

Hi,

On 10/18/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Sun, Oct 16, 2005 at 08:43:27PM +0800, Zuxy wrote:
> > 2005/10/16, Vladimir Mosgalin <mosgalin at vm10124.spb.edu>:
> > >
> > > Though I'm not a developer, I have some suggestions:
> > > 1) You'd better send text files with LF endings. People around here
> > >    don't like text files in dos format ;)
> >
> > I really don't think so....CRLF isn't that bad, is it?
>
> It's annoying...
>
> > > 2) WTF is "main.new\cpudetect.c"?? GNU patch (2.5.4) doesn't understand
> > >    stuff like this, I had to convert them to "/" manually. I strongly
> > >    suggest you to resend patch with correct dir separators.
> >
> > Just conventinal. I'm using mplayer under win32 and I'm developing
> > under mingw32.
>
> Then use Cygwin to create your patches.  That's how I work on Windows
> boxes.  Only compile under MinGW, do the rest under Cygwin.
>
> Patch rejected, I can't apply it.  Resend something sane.

The versions of patch that I use on my windows (mingw) or unix box
have no problem dealing with CR/LF line ending and "/" or "\" as
sub-directory separator.

Guillaume
--
Reading doesn't hurt, really!
 -- Dominik 'Rathann' Mierzejewski