[MPlayer-dev-eng] Small changes to subreader.c file

Rich Felker dalias at aerifal.cx
Mon Oct 17 07:20:43 CEST 2005


On Mon, Oct 17, 2005 at 12:24:14AM -0400, Ergzay wrote:
> On 2005/10/16, at 9:11, Dominik 'Rathann' Mierzejewski wrote:
> >On Sunday, 16 October 2005 at 08:37, Jindrich Makovicka wrote:
> >>Adam Tla??ka wrote:
> >>>I am waiting for final developers decision and that's all.
> >>>Your point is known and type of argumentation too.
> >>
> >>i vote for -dump-eol <lf|cr|crlf> with native ending as default.
> >
> >I vote for leaving things as they are and adding a note to the manpage
> >or the docs about the different line endings. Anyone should be able
> >to use unix2dos/dos2unix and we don't need to implement that in 
> >MPlayer.
> 
> Someone correct me if I'm wrong, but Mac OS X doesn't have 
> dos2unix/unix2dos. What if Mac OS X users want to use CRLF line endings 
> for their sub files? I am for adding an option to mplayer to change 
> what type of line ending output to use.

unix2dos:
#!/bin/sh
sed "s/$/`echo -ne '\r'`/"

dos2unix:
#!/bin/sh
tr -d '\015'

I'm sure there are cleaner and slightly more portable ways to write it
(e.g. with awk or perl) if you feel like spending more than the 5
seconds i spent on it..

Rich




More information about the MPlayer-dev-eng mailing list