[MPlayer-dev-eng] [PATCH] CPU detection related
Vladimir Mosgalin
mosgalin at VM10124.spb.edu
Sun Oct 16 14:20:53 CEST 2005
Hi Zuxy!
On 2005.10.16 at 19:12:20 +0800, Zuxy wrote next:
> cputable.h.diff contains information update, bug fixes and punctuation
> modifications to the original cputable.h. I suppose there's no reason
> to reject it:-)
Though I'm not a developer, I have some suggestions:
1) You'd better send text files with LF endings. People around here
don't like text files in dos format ;)
2) WTF is "main.new\cpudetect.c"?? GNU patch (2.5.4) doesn't understand
stuff like this, I had to convert them to "/" manually. I strongly
suggest you to resend patch with correct dir separators.
3) You misunderstood the idea about splitting a patch to several small
ones. You shouldn't make a separate patch for every file you modify;
patch cpudetect.c.diff will break compilation if applied without
cpudetect.h.diff - what's the point in splitting them then? It's
confusing..
4) Why don't you add a codename of my sempron processor too? ;)
processor : 0
vendor_id : AuthenticAMD
cpu family : 15
model : 44
model name : AMD Sempron(tm) Processor 2800+
stepping : 2
cpu MHz : 2663.728
cache size : 256 KB
fdiv_bug : no
hlt_bug : no
f00f_bug : no
coma_bug : no
fpu : yes
fpu_exception : yes
cpuid level : 1
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx mmxext fxsr_opt lm 3dnowext 3dnow pni lahf_lm
bogomips : 5275.64
Right now without your patch mplayer detects it as
CPU: Advanced Micro Devices (Family: 15, Stepping: 2)
With your patch, it's
CPU: AMD Sempron(tm) Processor 2800+ (Family: F, Model: 2C, Stepping: 2)
Its codename is Paris, if I'm not mistaken.
--
Vladimir
More information about the MPlayer-dev-eng
mailing list