[MPlayer-dev-eng] [PATCH] demuxers: move resync_audio_stream call to demuxer.c
Guillaume POIRIER
poirierg at gmail.com
Sun Oct 16 14:06:44 CEST 2005
Hi,
On 10/15/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> On Fri, Oct 14, 2005 at 09:38:46PM +0200, Reimar Döffinger wrote:
> > the attached patch adds a call to resync_audio_stream to demuxer.c after
> > seeking and switch_audio. IMHO this is where it belongs, not the
> > individual demuxers.
> > demuxer.c is still missing the prototype for the resync_audio_stream.
> > Would you find a special prototype or #include "libmpcodecs/dec_audio.h"
> > preferable?
> > I don't think so, but it might be that this has a a negative effect on
> > A-V sync after seeking, please check.
>
> Ok, a fixed version, including the prototype and fixes the switch_audio
> function to throw away the already demuxed audio packets before
> attempting to switch. Advantage: It should reduce the noise when audio
> is actually switched. Disadvantage: you will usually have a gap in the
> audio and little desync when doing switch_audio even when it isn't
> implemented.
It works really nice here on DVD (the same as without the patch).
Reimar, what would be the worst case scenario to witness such a gap or
slight desync?
Guillame
--
Reading doesn't hurt, really!
-- Dominik 'Rathann' Mierzejewski
More information about the MPlayer-dev-eng
mailing list