[MPlayer-dev-eng] [PATCH] for correct restoring window positions in gmplayer

[Guillaume POIRIER]

Hi,

On 10/3/05, Lutz Mändle <lmaendle at gmx.net> wrote:
> Hi,
> I've found a way for correct restoring of the window positions in gui
> mode. The trick is, to create the windows with 0,0 as x,y-positions and
> after make the windows visible move them to the stored positions. The
> stored positions can be negative, which is correct, if the window is on
> the left or top border, but if the window is created with such
> coordinates, it seems to sit beyond the right respectively bottom border
> of the screen.

When you mean "restoring" do you mean re-using the same apparent
window during the life cycle of the same instance of MPlayer?

Could you add some doxygen comments to your patch (see
http://www4.mplayerhq.hu/DOCS/tech/code-documentation.txt) so that
your solution for restoring the position makes some sense for a
newcomer?

> The patch is tested against cvs from 3. oct. 2005 and can applied with
> the following command: patch -p0 < patch.txt, if the patch.txt resides
> in the main directory.

Maybe it's my email client that sucks, but your patch was inlined on
the body of your mail (I suspect it's due to the .txt file extension).

[..]

> -          mplFullScreen();
> -          btnModify( evFullScreen,btnPressed );
> -         }
> +         mplFullScreen();
> +         btnModify( evFullScreen,btnPressed );
> +        }

Cosmetics changes.

Guillaume
--
Reading doesn't hurt, really!
  -- Dominik 'Rathann' Mierzejewski