[MPlayer-dev-eng] [PATCH] configure to detect prescott and nocona

Corey Hickey bugfood-ml at fatooh.org
Sat Oct 15 09:44:42 CEST 2005


Zuxy wrote:
> Athlon64 is not the only choice in AMD64.

>From your patch:
----------------------------------------------
+    if test "pvendor" = "AuthenticAMD" ; then
     proc=k8
-
+    else
+        proc=nocona
+    fi
----------------------------------------------

You forgot a '$' before pvendor.

Anyway, it might be nicer to use a case...esac statement here just like
the way the i386 section is set up. See line 783 in the (unpatched)
configure. Even though there are only two choices now, I expect that in
the future other CPU vendors will make their own x86_64 chips and we'll
end up wanting to use case anyway.

I don't know what a good default case would be; as far as I know there
isn't any "generic" x86_64 CPU type.

-Corey




More information about the MPlayer-dev-eng mailing list