[MPlayer-dev-eng] [PATCH] mencoder to load win32 codecs properly

[Zuxy]

2005/10/14, Sascha Sommer <saschasommer at freenet.de>:
> On Friday 14 October 2005 08:35, Zuxy wrote:
>
> I don't know. $PATH is $PATH. When it doesn't contain the entries it contained
> when you started MPlayer there might also be a problem when you start
> external programs from within MPlayer like the osdmenu does or other
> functions that rely on $PATH. Completely ignoring $PATH is not something I'd
> expect from an app. It is not that much of an issue, though.
> So if you say that statement is crap we can as well leave it out.
>
> The best would be to call LoadLibrary with the full path anyway. The only
> difficulty there is that dlls, that rely on other dlls in the same dir, won't
> be able to find these dlls.

Or we can use SetDllDirectory (see
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/setdlldirectory.asp)
to add WIN32_PATH to the DLL search directories, leaving $PATH as is.
It affects all subsequent calls to LoadLibrary. Two problems remain:
1. SetDllDirectory is available only in Windows XP SP1 or newer; 2. We
can't set different WIN32_PATH and REALCODEC_PATH.

>
> I think I'll commit the patch as is (without some of the mp_msgs). If it is
> wanted the other issue can still be changed later.

Thanks.

--
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6