[MPlayer-dev-eng] [PATCH] mencoder to load win32 codecs properly

[Zuxy]

2005/10/13, Sascha Sommer <saschasommer at freenet.de>:
> On Thursday 13 October 2005 14:51, Reimar Döffinger wrote:
>
> Yes, it is what the current code does, but I think it will also try to load
> the dll from windows/system32 first, ignoring $PATH. I only thought that it
> might be usefull to add additional paths without having to recompile MPlayer.
>

To do that I think the best way is to add an mplayer option instead of
relying on $PATH.

And to Sascha, I'm not quite familiar for the security implication of
string operations. What I do is just to move the code from mplayer.c
to get_path.c, replace the hardcoded filename and add some message
outputs, which may need further modification as you suggested. So may
I say the patch is at least as secure as the original code? And since
WIN32_PATH is a compile-time constant I don't think it'll be utilized
to cause a buffer overflow at runtime by a hacker. Anyway, if we added
the option mentioned above we should take further consideration.

So, I'd better resend the patch or you would edit it yourself? Thanks.

--
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6