[MPlayer-dev-eng] [PATCH] cross-compile: add --enable-cross-compile

Oded Shimon ods15 at ods15.dyndns.org
Thu Oct 13 19:14:37 CEST 2005


On Thu, Oct 13, 2005 at 07:02:43PM +0200, Diego Biurrun wrote:
> On Thu, Oct 13, 2005 at 12:13:04AM +0200, Aurelien Jacobs wrote:
> > 
> > --- ../main.test2/configure	2005-10-12 23:27:51.000000000 +0200
> > +++ configure	2005-10-12 23:50:14.000000000 +0200
> > @@ -54,6 +54,7 @@
> >  }
> >  
> >  tmp_run() {
> > +  test $_cross_compile = yes && return 0
> >    "$TMPO" >> "$TMPLOG" 2>&1
> >  }
> 
> This may slow things down, since that test is run many many times.  Why
> not overload that function in the cross-compilation case?

It really really really won't. "test" is an internal bash call, not a 
seperate program, so running it is near nothing, and the 'gcc' calls are 
like 99.9% of the time anyway. You're basically saving an "strcmp"...

I'm a bit more curious if this doesn't break any functionality, that is, 
will not running these tests actually give some wrong results?.. If it 
does, then it's a problem, and if it doesn't, then why do we run the tests 
at all?...

- ods15




More information about the MPlayer-dev-eng mailing list