[MPlayer-dev-eng] Small changes to subreader.c file

[Adam Tlałka]

Dnia Wed, 12 Oct 2005 09:47:53 +0200, Ivan Kalvachev  
<ikalvachev at gmail.com> napisał:

> ---------- Forwarded message ----------
> From: A I <ai4spam gmail.com>
> Date: 2005-10-12 4:40
> Subject: Re: .srt format specifications.
> To: Ivan Kalvachev <ikalvachev gmail.com>
> Cc: submagic netcourrier.com, "jeinrem post.cz" <jeinrem post.cz>
>
>
> Well, in my opinion, since SubRip is a Windows program (until someone
> decides to compile it with Kylix), we should use the Windows CRLF.
> That is the standard, AFAIK.
> As for compatibility, it's not really your fault, it's the firmware
> developper's fault.
> I agree, however, that an "official" spec would be nice to have.
>
> -ai4spam
> ----------End of Forwarded message ----------
>
> Well this is the current maintainer of SubRip, he is  working on
> second version of srt. I guess we will have specs for it.
> I  couldn't find working email of the original author (first one in
> the cc doesn't work for sure). But as we already know that even the
> Kylix version will produce CRLF, we can conclude that this is by
> purpose.
>
> The strongest and only argument against CRLF is that we must use the
> native OS text convention.

But you just wrote that Kyllix will produce CRLF version on Linux.
So on a Kylix version of MPlayer (if it was written in Pascal) it
would produce CRLF as a native text output.

In this case we could get different outputs depending on which
language/compiler we use under same OS! What a big mess!
So what is the native format in this situaction?
Kyllix case shows us that is is undefined. :(

In my opinion we should use always a format in which particular
subtitle file type was designed or first appeared.
So I changed my mind a little. Formats which appeared as LF only
should stay as they are and the same to DOS ones - CRLF will be there.
I think now that this could be the most compatible solution.
Last version of my patch - 2a.patch - provides this.

Regards
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl