[MPlayer-dev-eng] [PATCH]cr/lf line endings of dumped subtitles

Adam Tlałka atlka at pg.gda.pl
Wed Oct 12 18:05:20 CEST 2005


Dnia Wed, 12 Oct 2005 17:48:37 +0200, Rich Felker <dalias at aerifal.cx>  
napisał:

> On Wed, Oct 12, 2005 at 03:59:40PM +0200, Adam Tla??ka wrote:
>> Hi,
>>
>> 2.patch -> subreader.c: cr/lf line ending output of subtitle dump file
>> format added
>> The output file is openned in "wb" mode so we always get what we write.

After all this flame war I can't see strong points in Ritch's  
argumentation.
I am not convinced.
So the patch is as is.
Of course changeing JACOsub and mpsub format by me was a mistake.
But not in other cases. I just can't make it optional if it should
be the standard.
So now you must decide.
Accept or reject or do it other way.
It's up to you as it always be :-)

> Please ignore this patch. If Adam still refuses to send a correct
> patch I will write one myself in a few days.
You are the code master but that doesn't automatically mean that you are  
right.
But the choise is of course yours.

Regards
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl




More information about the MPlayer-dev-eng mailing list