[MPlayer-dev-eng] [PATCH]cr/lf line endings of dumped subtitles

Guillaume POIRIER poirierg at gmail.com
Wed Oct 12 16:14:15 CEST 2005


Hi,

On 10/12/05, Adam Tlałka <atlka at pg.gda.pl> wrote:
> Hi,
>
> 2.patch -> subreader.c: cr/lf line ending output of subtitle dump file
> format added
> The output file is openned in "wb" mode so we always get what we write.

It would be very nice if you could use a name that makes sense for your patches.

Other than that, your patch do not seem to feature an _optionnal_
"CR/LR line ending mode".

This patch has therefore a very little chance to get applied.

Guillaume
--
Reading doesn't hurt, really!
  -- Dominik 'Rathann' Mierzejewski


More information about the MPlayer-dev-eng mailing list