[MPlayer-dev-eng] [PATCH] cross-compile: dshow cleanup

[Diego Biurrun]

On Wed, Oct 12, 2005 at 12:32:54AM +0200, Aurelien Jacobs wrote:
> On Mon, 10 Oct 2005 12:28:27 +0200
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 
> > On Sun, Oct 09, 2005 at 11:47:08PM +0200, Aurelien Jacobs wrote:
> > > Here is the first one. It cleans up a little bit the way than dshow
> > > is detected so that it works the same way as LIVE555 (use cc_check
> > > instead of a direct call of $_cc).
> > 
> > Maybe it's overkill, but how about a special cxx_check function or so?
> 
> Indeed, that seems to be the right way to go.
> And the attached patch is pretty simply so it's probably not overkill.
> Anyone disagree with this patch ?

Commit.  Just one nit..

> @@ -5726,9 +5732,7 @@
>  
>  echocheck "LIVE555 Streaming Media libraries"
>  if test "$_live" = auto  && test "$_network" = yes ; then
> -  _TMPC=$TMPC
> -  TMPC=$TMPCPP
> -  cat >$TMPC <<EOF
> +  cat >$TMPCPP <<EOF

While you're at it, please add spaces around the > and <<, it helps
readability quite a bit IMO.

Diego