[MPlayer-dev-eng] Re: Small changes to subreader.c file

Andriy N. Gritsenko andrej at lucky.net
Mon Oct 10 08:53:07 CEST 2005


    Hi, Rich Felker!

Sometime (on Friday, October  7 at 22:40) I've received something...
>> I am sending a small patch which adds "\r\n" (DOS line endings) to  
>> dump_srt function
>> which is a bug correction because SRT is really a DOS format and will not  
>> be
>> properly read with Unix like "\n" line endings.

>This is not a bug. .srt files are text files and as such should be
>stored in (standard) unix text format. If windows/dos/mac/etc users
>want to use them they can apply the appropriate (broken) textfile
>conversions.

    Tell me, please, which window$ user will search for conversion tool
when he just goes to see some avi file with srt subtitles? I've sometime
tried to see it with srt files with no LF in it. I've tried two players
under window$ (no other OS was there!) and some subtitles was as crap.
I've got blamed for crap subtitles. You want to be blamed forever? SRT
file isn't just text file but file in special format which contains text
lines. So let it be in native format, which is with CRLF on end of each
line!

    With best wishes.
    Andriy.




More information about the MPlayer-dev-eng mailing list