[MPlayer-dev-eng] Small changes to subreader.c file

Adam Tlałka atlka at pg.gda.pl
Thu Oct 6 13:05:01 CEST 2005


Dnia Thu, 06 Oct 2005 12:30:22 +0200, Diego Biurrun <diego at biurrun.de>  
napisał:

> On Thu, Oct 06, 2005 at 12:22:00PM +0200, Adam Tla??ka wrote:
>>
>> I am sending a small patch which adds "\r\n" (DOS line endings) to
>> dump_srt function
>> which is a bug correction because SRT is really a DOS format and will  
>> not
>> be properly read with Unix like "\n" line endings.
>>
>> Next is some additional debug info in adjust_subs_time function which
>> helps us to find incorrect subtitle lines.
>
> If you make independent changes, send them as separate patches.
OK now you have them in separate files.

> Your patch contains cosmetic whitespace changes, remove them.
OK.

> Patch rejected.
Nice ;-)) two blank lines and so many time wasted to this comversation
and making two independent diff files.

Regards
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subreader.patch1
Type: application/octet-stream
Size: 968 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051006/c5215c9f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subreader.patch2
Type: application/octet-stream
Size: 812 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051006/c5215c9f/attachment-0001.obj>


More information about the MPlayer-dev-eng mailing list