[MPlayer-dev-eng] [PATCH] use int_fast32_t in postproc/*

[Zoltan Hidvegi]

Reimar DĂśffinger wrote:
> Does AIX run on x86? Otherwise it wouldn't matter. Anyway:

Only PPC, and even there, probably only on IBM hardware.

> So how about the attached patch? What does everyone think?

Cool, I'm all for changing everything to long.  But when you change
from unsigned to signed, watch out for divide and modulo by constant
power of 2.  It's nice to write n/2, which is optimized to a shift if
n is unsigned, but for signed n, C has this stupid round towards 0
rule, which requires a bunch of extra instructions.  Scanning your
patch, there are a few places where this happens (end = s + size/2
like stuff), but it seems that all of those are outside of any loops,
so happen only once per frame, so it's not really an issue.  Once can
argue that size/2 is more readable than (size>>1), so it may be better
to leave it.

Zoli