[MPlayer-dev-eng] [PATCH] configure cleanup

Diego Biurrun diego at biurrun.de
Tue Oct 4 13:29:39 CEST 2005


On Mon, Oct 03, 2005 at 11:44:28AM +0200, Reimar Döffinger wrote:
> > >  echocheck "DPMS"
> > >  _xdpms3=no
> > > +_xdpms4=no
> > 
> > Hmm, why?  I think the variable is unnecessary in any case.
> 
> Huh? It is used in several places, and it is my opinion that all
> variables should be either "yes" or "no" after configure.
> Anyway, I just moved this up from a few lines below, so I could get rid
> of one test "$_x11" = yes check.

OK, this test does not check for dpms=auto or something and the variable
is not initialized in the beginning, so your version is OK.

Diego




More information about the MPlayer-dev-eng mailing list