[MPlayer-dev-eng] Re: [PATCH] make demuxer_get_percent_pos() recheck file length

[Reimar Döffinger]

Hi,
On Sun, Oct 02, 2005 at 10:45:17AM +0200, Alban Bedel wrote:
> The fd field could be anything (ie there not even a guarentee that
> it acctually hold a fd), so just lseek'ing it blindly is not acceptable.
> Instead this should be implemented with a control call on the stream.

The stream should not be access directly either. If at all, a demuxer
call that will then if necessary call a stream function. Some demuxers
will always know the length (e.g. mov and mpc).
Might also be possible to make the demuxers that do not know the right
length update the movie_end entry when the  GET_PERCENT_POS demuxer control
is called.
It definitly needs to be thought through to make it not a hack.

Greetings,
Reimar Döffinger