[MPlayer-dev-eng] [PATCH] remove limits from af_equalizer

[Reynaldo H. Verdejo Pinochet]

Hi Corey

On Tue, Nov 29, 2005 at 06:48:59PM -0800, Corey Hickey wrote:
> 
> It's not really a high priority of mine -- I just noticed that it could
> be done and probably should. Here are the reasons:
> 
> * It's possible to pass af_equalizer one or more suboptions of 12 that
> causes it to clip with audio that is loud but still of fairly "usual"
> volume. So, a maximum of 12 doesn't necessarily protect users from
> themselves.
> 
> * Conversely, values higher than 12 may not cause clipping with quieter
> audio. In this case, 12 is an artificial restriction.
> 
> * af_volume is an easy way to enforce clipping if necessary and can use
> soft clipping, which may be desirable.

All this leaves me the impresion youre measuring efectivity/usability
of the filter by means of his ability to *clip* rather than his hability 
to correctly filter/boost a given freq range.

AFAIK eq filters are used mainly to work over a given dynamic range
using cutoff freqs to (among other things) *avoid* clipping

> 
> * Suboptions with values much lower than 12 have hardly any effect.
> While they aren't really useful, there's no danger in allowing them.
> 

may a wider bost range be enough? not that Im against leaving it unrestricted
but I wanna be sure why ;) especially on changes that can lead users
to wrong / bad results.

> * af_pan used to have hardcoded limits as well. A while ago I submitted
> a patch that raised those limits considerably and implemented clipping,
> but Reimar pointed out that af_volume should be used instead. He applied
> a patch that removed the limits. Doing the same thing to af_equalizer
> would be consistant with that change.
> 
> -Corey

Best regards

   Reynaldo H. Verdejo Pinochet
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051130/4536834e/attachment.pgp>