[MPlayer-dev-eng] [PATCH] clean up some muxer messages

[Rich Felker]

On Mon, Nov 21, 2005 at 04:38:01PM -0800, Corey Hickey wrote:
> As promised, here is a patch that converts the hardcoded strings I added
> to the muxer frame buffer into MSGTR_ messages. I also converted the AVI
> header-writing and index-writing messages into more accurate
> muxer-specific versions. In detail:
> 
> * Converted new strings in muxer_write_chunk to MSGTR_*

Good.

> * Moved MSGTR_WritingAVIHeader from mencoder.c section to muxer section
> * Added MSGTR_WritingMPEGHeader and MSGTR_WritingLAVFHeader

IMO these additional messages are both unnecessarry and confusing.
Especially since there is no thing as a "lavf header", but rather a
specific header type for each file type lavf supports.

The easiest solution is just to use messages like "writing header" and
"writing trailer" without mentioning the format. Or you could try to
do something more elaborate if it makes sense..

> * Put muxer-specific header-writing messages in individual muxers

Good.

> * Changed MSGTR_WritingAVIIndex to MSGTR_WritingAVITrailer
> * Added MSGTR_WritingMPEGTrailer and MSGTR_WritingLAVFTrailer

Same as above.

> * Put muxer-specific trailer-writing messages in individual muxers
> * Removed MSGTR_FixupAVIHeader (the mp_msg() in each muxer will suffice)
> * #include "help_mp.h" where necessary

Good.

Rich