[MPlayer-dev-eng] [PATCH] wrong M_OPT_RANGE checking on vrc_minrate / vrc_maxrate

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Mon Nov 28 22:10:20 CET 2005


Acording to man page vrc_minrate and vrc_maxrate both have
default values = 0 but the range alowed by the suboption
parser is [4,24000000], the vrc_minrate one was spoted by dalias
on irc a week ago altough it applies to vrc_maxrate too.

will commit if no one complains.

Best regards

   Reynaldo H. Verdejo Pinochet

ps: dunno why it was '4' before
-------------- next part --------------
Index: ./libmpcodecs/ve_lavc.c
===================================================================
RCS file: /cvsroot/mplayer/main/libmpcodecs/ve_lavc.c,v
retrieving revision 1.120
diff -a -u -r1.120 ve_lavc.c
--- ./libmpcodecs/ve_lavc.c	18 Nov 2005 14:39:22 -0000	1.120
+++ ./libmpcodecs/ve_lavc.c	28 Nov 2005 21:08:37 -0000
@@ -207,8 +207,8 @@
 	{"vqmod_freq", &lavc_param_rc_qmod_freq, CONF_TYPE_INT, 0, 0, 0, NULL},
 	{"vrc_eq", &lavc_param_rc_eq, CONF_TYPE_STRING, 0, 0, 0, NULL},
 	{"vrc_override", &lavc_param_rc_override_string, CONF_TYPE_STRING, 0, 0, 0, NULL},
-	{"vrc_maxrate", &lavc_param_rc_max_rate, CONF_TYPE_INT, CONF_RANGE, 4, 24000000, NULL},
-	{"vrc_minrate", &lavc_param_rc_min_rate, CONF_TYPE_INT, CONF_RANGE, 4, 24000000, NULL},
+	{"vrc_maxrate", &lavc_param_rc_max_rate, CONF_TYPE_INT, CONF_RANGE, 0, 24000000, NULL},
+	{"vrc_minrate", &lavc_param_rc_min_rate, CONF_TYPE_INT, CONF_RANGE, 0, 24000000, NULL},
 	{"vrc_buf_size", &lavc_param_rc_buffer_size, CONF_TYPE_INT, CONF_RANGE, 4, 24000000, NULL},
 	{"vrc_buf_aggressivity", &lavc_param_rc_buffer_aggressivity, CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 99.0, NULL},
 	{"vrc_init_cplx", &lavc_param_rc_initial_cplx, CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 9999999.0, NULL},
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051128/22953be6/attachment.pgp>


More information about the MPlayer-dev-eng mailing list