[MPlayer-dev-eng] Re: [PATCH] OSD cleanup

[Alban Bedel]

On Sun, 27 Nov 2005 22:06:08 +0200
Ivan Kalvachev <ikalvachev at gmail.com> wrote:

> 2005/11/25, Alban Bedel <albeu at free.fr>:
> > On Fri, 18 Nov 2005 17:52:47 +0100
> > Diego Biurrun <diego at biurrun.de> wrote:
> >
> > > On Fri, Nov 18, 2005 at 01:53:02PM +0100, Alban Bedel wrote:
> > > > On Thu, 17 Nov 2005 23:46:45 +0200
> > > > Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> > > >
> > > > > The code seems to be committed and I find this new behaviour disgusting.
> > > > > When I cycle trough modes using 'o' i see one "osd disable" and 3 "osd
> > > > > enable" that also hide the timer mode, so it now basically less
> > > > > verbose that before "osd en/disable" patch.
> > > >
> > > > Hmm i really don't see what your are talking about, here nothing changed in
> > > > the behaviour of the osd command (tested with vo x11 and xv).
> > >
> > > Same here.  What is everybody talking about?
> >
> > The usual stuff, to cry out lound about un-checked facts, or flame
> > commiters on cvs-log their is ppl. To do contructive and helfull
> > things, like actually reviewing or testing patches before they are
> > applied, a lot less. Sad but well ...
> 
> Don't you think you are a litel bit too arrogant?
> You had messed something and then blindly refuse to acknowledge there
> is problem.

I never said there is no pb, i said that i didn't understood what _your_
pb was. Note that i wasn't even the only one to fail to understand,
that "bug report".
 
> Well, If you had tried to cycle through osd levels with 'o' key you
> would have notice that "osd enable" doesn't vanish and keeps staying
> covering the OSD timer (that is visible at osd_leves 2 and 3).

>From this it sound like the msg stay there forever once you are in
level > 1 and no it doesn't do that here.

> I had given you more than enough time to fix it by yourself, but you
> were ignorant.

Next time try to get yourself understood that's a lot more effective
than inflamatory pseudo bug report.

> So I make some patch I can just hope it is right(tm).

At last something constructive, now i can at least understand what your
pb is. So the msg stay a few ms too much, imho that wasn't worse
the bit of code needed but that's no pb to fix.

> Patch attached. If there is not better fix I will apply it (soon).

That's just a hack instead the msg should be kicked from the stack
if you want it to diseaper right away. I'll do a proper fix.

	Albeu