[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[Ivan Kalvachev]

2005/11/27, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
> On Sunday, 27 November 2005 at 18:34, Diego Biurrun wrote:
> > On Sun, Nov 27, 2005 at 03:04:56AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > > On Sunday, 27 November 2005 at 02:44, The Wanderer wrote:
> > > > On 11/13/2005 05:38 PM, Dominik 'Rathann' Mierzejewski wrote:
> > > >
> > > > >On Sunday, 13 November 2005 at 20:07, Roberto Togni wrote:
> > > > >
> > > > >>There was both seek functions returning int and seek functions
> > > > >>returning void before the demuxer patch, but in every case the
> > > > >>return value was ignored. Probably i forgot to change these to
> > > > >>void. If we prefer to change them all to int we can talk about it,
> > > > >>but if we don't do anything with the result i see no reason to do
> > > > >>it.
> > > > >
> > > > >The return values are indeed ignored everywhere. Here's a patch that
> > > > >makes all the remaining non-void demuxer seek/close functions void.
> > > > >Apply it or decide on the return value semantics. ;)
> > > >
> > > > What's the status of this patch?
> > >
> > > Undecided, because Reimar and Rich didn't agree either way.
>
> And Roberto. ;)
>
> > Try to isolate the uncontroversial parts and commit those then.
>
> Here's what I'd like to commit:
>
> R.

-	 if (test_mix_index = strchr(mix_name, ',')){
+	 if ((test_mix_index = strchr(mix_name, ','))){

this looks a little pointless. maybe there is something missing?