[MPlayer-dev-eng] Re: error while playing streams over ipv6

Alban Bedel albeu at free.fr
Fri Nov 25 13:09:30 CET 2005


On Fri, 25 Nov 2005 19:30:14 +0800
qwen dux <qwendu at gmail.com> wrote:

> i found that in  libmpdemux/url.c
> where url_new() calling url_escape_string() to create unescaped/escaped
> versions of url, url_escape_string() simply escapes '[' and ']' and turn them
> into %5B and %5D,
>         But from line 133 to line 145 url_new() tries to find '[' and ']' again
> (which has been escaped already) to determine whether url is an ipv6 addr...
>         so i added slapdash from line 287   to line 289:
> else if(c=='[' || c==']'){
>                         *outbuf++=c;
>                 }

You should send a patch instead (see the docs for more details).
Anyway this doesn't look like an acceptable solution, [] do need to be
escaped normaly. Instead we probaly need some special handling for the
escaping of the hostname part.

	Albeu




More information about the MPlayer-dev-eng mailing list