[MPlayer-dev-eng] fix dynamic dvd drive selection on darwin
diego at biurrun.de
Sat Nov 19 16:02:39 CET 2005
On Sat, Nov 19, 2005 at 03:41:10AM +0100, Emanuele Giaquinta wrote:
> Forget the previous patch for now; I've found that dvd_reader.c does not
> define SYS_BSD on osx, as it should, cause there is no test for
You mean no configure test?
> and __DARWIN__ is not defined on osx.
You mean in MPlayer or OS X in general?
> The attached patch
> fixes this. Now, since the rdisk devices are raw, how can the dynamic
> dvd selection ever work? DVDOpen just calls DVDOpenImageFile in the
> SYS_BSD case, which is the right one, and its return value is not a valid
> way to check that the device is associated to a dvd drive. IMO it is
> better to revert to the traditional behaviour using rdisk1 as the
> default dvd device.
I'd apply this patch, but does it fix the problem in the end?
More information about the MPlayer-dev-eng